sscoble/brand-site
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Close resolved issues #48 #62 - privacy policy already updated #68

Merged
sscoble merged 1 commit from close-resolved-issues into main 2026-05-05 18:12:03 +00:00
Conversation 0 Commits 1 Files changed 1 +9
sscoble commented 2026-05-05 17:49:53 +00:00
Owner
Copy link

Closes #48 and #62.

Both issues were already resolved in deployed code:

  • #48: Privacy policy was updated to explicitly mention Umami Analytics (cookieless, first-party, no personal data)
  • #62: Verified no cookie consent banner needed since Umami uses localStorage, not cookies

No code changes needed - just closing the issues now.

Closes #48 and #62. Both issues were already resolved in deployed code: - #48: Privacy policy was updated to explicitly mention Umami Analytics (cookieless, first-party, no personal data) - #62: Verified no cookie consent banner needed since Umami uses localStorage, not cookies No code changes needed - just closing the issues now.
sscoble added 1 commit 2026-05-05 17:49:53 +00:00 
#48: Privacy policy now explicitly mentions Umami analytics (cookieless, first-party, no personal data)
#62: Verified no cookie consent banner needed - Umami uses localStorage, not cookies

Both issues were resolved in deployed code but never closed.
sscoble merged commit 9f9563eb30 into main 2026-05-05 18:12:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Accessibility

  
blocked

   
bug

Something broken or incorrect

  
content

Content writing, migration, editing

  
content

Content additions or updates

  
conversion

CTAs, forms, signup flows

  
design

Visual design, layout, branding

  
feature

   
improvement

   
infrastructure

Site infrastructure, tooling, hosting

  
infrastructure

Build, deploy, CI/CD, hosting

  
landing-page

Landing page deliverable

  
priority:critical

Site is broken or misleading without this

  
priority:high

Important for launch credibility

  
priority:low

Nice to have, polish item

  
priority:medium

Should have before full launch

  
question

   
seo

Search engine optimization

No labels
a11y
blocked
bug
content
content
conversion
design
feature
improvement
infrastructure
infrastructure
landing-page
priority:critical
priority:high
priority:low
priority:medium
question
seo
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sscoble/brand-site#68
No description provided.
Delete branch "close-resolved-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?