mirror of
https://github.com/badlogic/pi-mono.git
synced 2026-11-05 23:37:25 +00:00
b2cb629237
Fixes #11692. ## Problem In RPC mode the startup catalog refresh runs in the background and also refreshes an expired OAuth credential. If pi exits after the token request went out but before the new token is written, the provider has already spent the old single-use refresh token and auth.json keeps only that one. The next request fails with `invalid_grant`. Trace: `pi --mode rpc` starts, `get_state` is answered, catalog refresh sends the token request, the client sends SIGTERM (or closes stdin), `shutdown()` runs `runtimeHost.dispose()`, which does not know about the refresh, and the process exits. Same for print and interactive mode, and for a prompt-time refresh cut off by an exit. ## Fix - `RuntimeCredentials.modify()` tracks every pending modification (same idiom as the MCP `track()` / `McpAuthProvider.settled()`). - `RuntimeCredentials.settled()` / `ModelRuntime.settleCredentialWrites()` wait for them. - `AgentSessionRuntime.dispose()` waits for them. All modes exit through `dispose()`. No extra timeout: the OAuth refresh (15 s) and the auth.json lock wait (30 s) are already bounded, and a second signal still exits at once. Not changed: the catalog refresh still refreshes expired OAuth credentials, also for providers whose catalog does not use them (the pi.dev catalog for `openai`, `anthropic`, ...). Skipping that would need a per-provider "catalog needs auth" signal in pi-ai; it is optional now that exits wait. `docs/rpc.md` now says that pi waits for pending work before exiting. ## Testing - `test/runtime-credentials.test.ts`: `settled()` waits until a pending modification is written, and resolves after a failed one. - `test/suite/regressions/11692-dispose-waits-for-oauth-refresh.test.ts`: `dispose()` waits until the token from a background catalog refresh is saved. Fails without the fix. - Real process: `pi --mode rpc` with an extension OAuth provider (expired credential, 400 ms refresh), SIGTERM about 100 ms after the token request started. Without the wait: 3 of 3 runs kept the spent refresh token. With the fix: 3 of 3 saved the new one (exit 143). Closing stdin instead of SIGTERM: new token saved, exit 0. - `npm run check`; `test/rpc*`, `test/print-mode`, `test/model-runtime*`, runtime and regression suites pass. |
||
|---|---|---|
| .. | ||
| regressions | ||
| agent-session-bash-persistence.test.ts | ||
| agent-session-boundaries.test.ts | ||
| agent-session-codemode.test.ts | ||
| agent-session-compaction-model-overrides.test.ts | ||
| agent-session-compaction.test.ts | ||
| agent-session-mcp-oauth.test.ts | ||
| agent-session-mcp.test.ts | ||
| agent-session-model-extension.test.ts | ||
| agent-session-prompt.test.ts | ||
| agent-session-queue.test.ts | ||
| agent-session-retry-events.test.ts | ||
| agent-session-runtime.test.ts | ||
| agent-session-tool-orchestration.test.ts | ||
| agent-session-tool-result-images.test.ts | ||
| harness.ts | ||
| lax-message-content.test.ts | ||
| mcp-oauth-server.ts | ||
| README.md | ||
| virtual-models.test.ts | ||
Coding agent suite tests
Use test/suite/ for the new harness-based test suite around AgentSession and AgentSessionRuntime.
Rules:
- Use
test/suite/harness.ts - Use the faux provider from
packages/ai/src/providers/faux.ts - Do not use real provider APIs, real API keys, network calls, or paid tokens
- Keep these tests CI-safe and deterministic
- Do not use or extend the legacy
test/test-harness.tspath unless a missing capability forces it