mirror of
https://github.com/badlogic/pi-mono.git
synced 2026-11-05 23:37:25 +00:00
fix(coding-agent): label skill diagnostics as [Skill warnings] (#11566)
At startup, interactive mode printed every skill diagnostic under the
heading `[Skill conflicts]`. Most of these are validation warnings for
skills that still load, for example `description exceeds 1024 characters
(1508)` or name-format warnings. The heading made them look like name
collisions.
This change renames the heading to `[Skill warnings]`. Validation and
loading behavior are unchanged. The prompt and theme headings are left
as they are.
**Testing**
- Updated the assertion in
`packages/coding-agent/test/interactive-mode-status.test.ts` ("still
shows diagnostics on quiet startup when requested") to expect `[Skill
warnings]`. It fails against the old heading and passes with the change.
All 37 tests in that file pass.
- `npm run check` reports six type errors in `packages/ai` tests about
model IDs. Unchanged `origin/main` reports the same six errors, so they
are unrelated to this change. It reports nothing in `coding-agent`.
Fixes #11521
Requested by @davidbrai
Co-authored-by: triagent <triagent@localhost>
This commit is contained in:
parent
0c3675e647
commit
f14813e965
2 changed files with 2 additions and 2 deletions
|
|
@ -2025,7 +2025,7 @@ export class InteractiveMode {
|
|||
if (skillDiagnostics.length > 0) {
|
||||
const warningLines = () => this.formatDiagnostics(skillDiagnostics, sourceInfos);
|
||||
this.loadedResourcesContainer.addChild(
|
||||
new ThemedText(() => `${theme.fg("warning", "[Skill conflicts]")}\n${warningLines()}`, 0, 0),
|
||||
new ThemedText(() => `${theme.fg("warning", "[Skill warnings]")}\n${warningLines()}`, 0, 0),
|
||||
);
|
||||
this.loadedResourcesContainer.addChild(new Spacer(1));
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1366,7 +1366,7 @@ describe("InteractiveMode.showLoadedResources", () => {
|
|||
});
|
||||
|
||||
const output = renderAll(fakeThis.loadedResourcesContainer);
|
||||
expect(output).toContain("[Skill conflicts]");
|
||||
expect(output).toContain("[Skill warnings]");
|
||||
expect(output).not.toContain("[Skills]");
|
||||
});
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue