sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-06 23:44:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(coding-agent): discover sessions through symlinked directories (#7552)

Browse source 
fixes #7497
This commit is contained in:
muyiyr 2026-08-04 00:34:12 +08:00 • committed by GitHub
parent a4475344fb
commit da66636cc4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 78 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/coding-agent/src/core/session-manager.ts
View file

@ -1672,7 +1672,9 @@ export class SessionManager {
return [];
}
const entries = await readdir(sessionsDir, { withFileTypes: true });
const dirs = entries.filter((e) => e.isDirectory()).map((e) => join(sessionsDir, e.name));
const dirs = entries
.filter((entry) => entry.isDirectory() || entry.isSymbolicLink())
.map((entry) => join(sessionsDir, entry.name));
// Count total files first for accurate progress
let totalFiles = 0;

75
packages/coding-agent/test/suite/regressions/7497-session-discovery-symlink.test.ts Normal file
View file

@ -0,0 +1,75 @@
import { mkdirSync, mkdtempSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { ENV_AGENT_DIR } from "../../../src/config.ts";
import { SessionManager } from "../../../src/core/session-manager.ts";
const DIRECTORY_LINK_TYPE = process.platform === "win32" ? "junction" : "dir";
describe("regression #7497: discover sessions through symlinked directories", () => {
let tempDir: string;
let sessionsDir: string;
beforeEach(() => {
tempDir = mkdtempSync(join(tmpdir(), "pi-session-discovery-"));
const agentDir = join(tempDir, "agent");
sessionsDir = join(agentDir, "sessions");
mkdirSync(sessionsDir, { recursive: true });
vi.stubEnv(ENV_AGENT_DIR, agentDir);
});
afterEach(() => {
vi.unstubAllEnvs();
rmSync(tempDir, { recursive: true, force: true });
});
function writeSession(dir: string, id: string): void {
mkdirSync(dir, { recursive: true });
writeFileSync(
join(dir, `${id}.jsonl`),
`${JSON.stringify({
type: "session",
version: 3,
id,
timestamp: "2026-08-03T00:00:00.000Z",
cwd: join(tempDir, "project"),
})}\n`,
);
}
it("discovers a session through a directory link and preserves the alias path", async () => {
const targetDir = join(tempDir, "linked-sessions");
writeSession(targetDir, "linked");
const aliasDir = join(sessionsDir, "--linked--");
symlinkSync(targetDir, aliasDir, DIRECTORY_LINK_TYPE);
const sessions = await SessionManager.listAll();
expect(sessions.map((session) => session.id)).toEqual(["linked"]);
expect(sessions[0]?.path).toBe(join(aliasDir, "linked.jsonl"));
});
it("ignores a broken directory link without hiding valid sessions", async () => {
writeSession(join(sessionsDir, "--regular--"), "regular");
const targetDir = join(tempDir, "removed-sessions");
mkdirSync(targetDir);
symlinkSync(targetDir, join(sessionsDir, "--broken--"), DIRECTORY_LINK_TYPE);
rmSync(targetDir, { recursive: true });
const sessions = await SessionManager.listAll();
expect(sessions.map((session) => session.id)).toEqual(["regular"]);
});
it.skipIf(process.platform === "win32")("ignores links to files", async () => {
writeSession(join(sessionsDir, "--regular--"), "regular");
const targetFile = join(tempDir, "not-a-directory");
writeFileSync(targetFile, "");
symlinkSync(targetFile, join(sessionsDir, "--file--"), "file");
const sessions = await SessionManager.listAll();
expect(sessions.map((session) => session.id)).toEqual(["regular"]);
});
});