sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-05 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(coding-agent): validate codemode image() base64 and detect image type

Browse source 
image() now rejects malformed base64 and data without a PNG, JPEG, GIF,
or WebP signature, and derives the MIME type from the signature. Invalid
image blocks were persisted and made every later provider request fail.

closes #10215
This commit is contained in:
Armin Ronacher 2026-09-30 12:10:30 +02:00
parent 3dd803d7e7
commit d2931ad3d5
5 changed files with 75 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/coding-agent/test/suite/agent-session-codemode.test.ts
View file

@ -417,7 +417,7 @@ describe("codemode options and store", () => {
const harness = await setup();
const result = await run(
harness,
'// @options: {"max_output_tokens": 10}\nfor (let i = 0; i < 100; i++) text("row " + i);\nimage("data:image/png;base64,AAAA");',
`// @options: {"max_output_tokens": 10}\nfor (let i = 0; i < 100; i++) text("row " + i);\nimage("data:image/png;base64,${TINY_PNG_BASE64}");`,
);
const details = result.details as unknown as CodemodeToolDetails;
const path = details.fullOutputPath;
@ -431,7 +431,7 @@ describe("codemode options and store", () => {
expect(text).not.toContain("row 50\n");
expect(text).toContain(`[Full output: ${path} (read with offset/limit)]`);
// Images follow the truncated text.
expect(result.content.at(-1)).toEqual({ type: "image", data: "AAAA", mimeType: "image/png" });
expect(result.content.at(-1)).toEqual({ type: "image", data: TINY_PNG_BASE64, mimeType: "image/png" });
expect(readFileSync(path, "utf8")).toBe(Array.from({ length: 100 }, (_, i) => `row ${i}`).join("\n"));
} finally {
rmSync(path, { force: true });