sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-05 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

handle lower case am/pm in macos screenshot names (#3194)

Browse source
This commit is contained in:
Jack Rose 2026-04-15 20:00:46 +10:00 • committed by GitHub
parent a3666344f4
commit d22c120b82
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/coding-agent/src/core/tools/path-utils.ts
View file

@ -9,7 +9,7 @@ function normalizeUnicodeSpaces(str: string): string {
}
function tryMacOSScreenshotPath(filePath: string): string {
return filePath.replace(/ (AM|PM)\./g, `${NARROW_NO_BREAK_SPACE}$1.`);
return filePath.replace(/ (AM|PM)\./gi, `${NARROW_NO_BREAK_SPACE}$1.`);
}
function tryNFDVariant(filePath: string): string {

15
packages/coding-agent/test/path-utils.test.ts
View file

@ -143,5 +143,20 @@ describe("path-utils", () => {
// This works because tryMacOSScreenshotPath() handles this case
expect(result).toBe(join(tempDir, macosName));
});
it("should handle macOS screenshot lowercase am/pm variant (en_AU locale)", () => {
// Some locales like en_AU use lowercase am/pm in screenshot names
const macosName = "Screenshot 2024-01-01 at 10.00.00\u202Fam.png"; // U+202F + lowercase
const userName = "Screenshot 2024-01-01 at 10.00.00 am.png"; // regular space + lowercase
// Create file with macOS-style name
writeFileSync(join(tempDir, macosName), "content");
// User provides regular space path
const result = resolveReadPath(userName, tempDir);
// This works because tryMacOSScreenshotPath() uses case-insensitive matching
expect(result).toBe(join(tempDir, macosName));
});
});
});