sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-05 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(coding-agent): warn when session-id creates a session

Browse source 
closes #6407
This commit is contained in:
Mario Zechner 2026-07-09 11:37:07 +02:00
parent 2170363af4
commit c4281a7dd1
3 changed files with 46 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

40
packages/coding-agent/test/session-id-readonly.test.ts
View file

@ -122,6 +122,46 @@ describe("--session-id read-only commands", () => {
expect(hasSessionWithId(join(result.agentDir, "sessions"), "read-only-models")).toBe(false);
});
it("warns when a missing --session-id creates a new session", async () => {
const result = await runCli((dirs) => [
"--session-dir",
dirs.sessionDir,
"--session-id",
"missing-session-id",
"--model",
"missing-model",
"-p",
"hi",
]);
expect(result.code).toBe(1);
expect(result.stderr).toContain(
"Warning: No project session found with id 'missing-session-id'; creating a new session with that id.",
);
});
it("does not warn when --session-id opens an existing session", async () => {
const result = await runCli(
(dirs) => [
"--session-dir",
dirs.sessionDir,
"--session-id",
"existing-session-id",
"--model",
"missing-model",
"-p",
"hi",
],
(dirs) => {
mkdirSync(dirs.sessionDir, { recursive: true });
writeSession(dirs.sessionDir, dirs.projectDir, "existing-session-id");
},
);
expect(result.code).toBe(1);
expect(result.stderr).not.toContain("No project session found with id 'existing-session-id'");
});
it("rejects an existing fork target session id", async () => {
const result = await runCli(
(dirs) => ["--session-dir", dirs.sessionDir, "--fork", "source-id", "--session-id", "existing-id", "-p", "hi"],