mirror of
https://github.com/badlogic/pi-mono.git
synced 2026-11-05 23:37:25 +00:00
fix(ai): prefer configured Bedrock profile over ambient AWS keys (#7176)
Bedrock profile configured via pi's auth flow was ignored when ambient AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY were set, because pi forced config.credentials from those keys and the SDK treats explicit credentials as overriding config.profile. Fixes #6957
This commit is contained in:
parent
04b15259b2
commit
b63403a50f
2 changed files with 123 additions and 2 deletions
|
|
@ -131,8 +131,14 @@ export const stream: StreamFunction<"bedrock-converse-stream", BedrockOptions> =
|
|||
|
||||
const blocks = output.content as Block[];
|
||||
|
||||
// A profile explicitly configured through pi's auth flow (the `profile`
|
||||
// option or scoped `AWS_PROFILE` on the stored credential's env) must win
|
||||
// over ambient AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY. The SDK default
|
||||
// chain already prefers a configured profile over env keys, but only when
|
||||
// `credentials` is not set on the client config. See #6957.
|
||||
const optionsProfile = options.profile || options.env?.AWS_PROFILE;
|
||||
const config: BedrockRuntimeClientConfig = {
|
||||
profile: options.profile || getProviderEnvValue("AWS_PROFILE", options.env),
|
||||
profile: optionsProfile || getProviderEnvValue("AWS_PROFILE", options.env),
|
||||
};
|
||||
const configuredRegion = getConfiguredBedrockRegion(options);
|
||||
const hasAmbientConfiguredProfile = Boolean(getProviderEnvValue("AWS_PROFILE"));
|
||||
|
|
@ -184,7 +190,7 @@ export const stream: StreamFunction<"bedrock-converse-stream", BedrockOptions> =
|
|||
}
|
||||
|
||||
const credentials = getConfiguredBedrockCredentials(options.env);
|
||||
if (!skipAuth && credentials) {
|
||||
if (!skipAuth && credentials && !optionsProfile) {
|
||||
config.credentials = credentials;
|
||||
}
|
||||
|
||||
|
|
|
|||
115
packages/ai/test/bedrock-credentials.test.ts
Normal file
115
packages/ai/test/bedrock-credentials.test.ts
Normal file
|
|
@ -0,0 +1,115 @@
|
|||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
const bedrockMock = vi.hoisted(() => ({
|
||||
constructorCalls: [] as Array<Record<string, unknown>>,
|
||||
}));
|
||||
|
||||
vi.mock("@aws-sdk/client-bedrock-runtime", () => {
|
||||
class BedrockRuntimeServiceException extends Error {}
|
||||
|
||||
class BedrockRuntimeClient {
|
||||
constructor(config: Record<string, unknown>) {
|
||||
bedrockMock.constructorCalls.push(config);
|
||||
}
|
||||
|
||||
send(): Promise<never> {
|
||||
return Promise.reject(new Error("mock send"));
|
||||
}
|
||||
}
|
||||
|
||||
class ConverseStreamCommand {
|
||||
readonly input: unknown;
|
||||
|
||||
constructor(input: unknown) {
|
||||
this.input = input;
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
BedrockRuntimeClient,
|
||||
BedrockRuntimeServiceException,
|
||||
ConverseStreamCommand,
|
||||
StopReason: {
|
||||
END_TURN: "end_turn",
|
||||
STOP_SEQUENCE: "stop_sequence",
|
||||
MAX_TOKENS: "max_tokens",
|
||||
MODEL_CONTEXT_WINDOW_EXCEEDED: "model_context_window_exceeded",
|
||||
TOOL_USE: "tool_use",
|
||||
},
|
||||
CachePointType: { DEFAULT: "default" },
|
||||
CacheTTL: { ONE_HOUR: "ONE_HOUR" },
|
||||
ConversationRole: { ASSISTANT: "assistant", USER: "user" },
|
||||
ImageFormat: { JPEG: "jpeg", PNG: "png", GIF: "gif", WEBP: "webp" },
|
||||
ToolResultStatus: { ERROR: "error", SUCCESS: "success" },
|
||||
};
|
||||
});
|
||||
|
||||
import type { BedrockOptions } from "../src/api/bedrock-converse-stream.ts";
|
||||
import { stream as streamBedrock } from "../src/compat.ts";
|
||||
import { getBuiltinModel } from "../src/providers/all.ts";
|
||||
import type { Context, Model } from "../src/types.ts";
|
||||
|
||||
const context: Context = {
|
||||
messages: [{ role: "user", content: "hello", timestamp: Date.now() }],
|
||||
};
|
||||
|
||||
async function captureClientConfig(
|
||||
model: Model<"bedrock-converse-stream">,
|
||||
options: BedrockOptions = {},
|
||||
): Promise<Record<string, unknown>> {
|
||||
bedrockMock.constructorCalls.length = 0;
|
||||
await streamBedrock(model, context, { cacheRetention: "none", ...options }).result();
|
||||
expect(bedrockMock.constructorCalls).toHaveLength(1);
|
||||
return bedrockMock.constructorCalls[0];
|
||||
}
|
||||
|
||||
describe("bedrock credential priority", () => {
|
||||
afterEach(() => {
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
it("prefers explicit and scoped profiles over ambient AWS access keys", async () => {
|
||||
vi.stubEnv("AWS_ACCESS_KEY_ID", "AKIAEXAMPLE");
|
||||
vi.stubEnv("AWS_SECRET_ACCESS_KEY", "secretexample");
|
||||
const model = getBuiltinModel("amazon-bedrock", "us.anthropic.claude-opus-4-8");
|
||||
|
||||
let config = await captureClientConfig(model, { profile: "explicit-profile" });
|
||||
|
||||
expect(config.profile).toBe("explicit-profile");
|
||||
expect(config.credentials).toBeUndefined();
|
||||
|
||||
config = await captureClientConfig(model, { env: { AWS_PROFILE: "scoped-profile" } });
|
||||
|
||||
expect(config.profile).toBe("scoped-profile");
|
||||
expect(config.credentials).toBeUndefined();
|
||||
});
|
||||
|
||||
it("uses ambient AWS access keys when no profile is configured", async () => {
|
||||
vi.stubEnv("AWS_ACCESS_KEY_ID", "AKIAEXAMPLE");
|
||||
vi.stubEnv("AWS_SECRET_ACCESS_KEY", "secretexample");
|
||||
const model = getBuiltinModel("amazon-bedrock", "us.anthropic.claude-opus-4-8");
|
||||
|
||||
const config = await captureClientConfig(model);
|
||||
|
||||
expect(config.profile).toBeUndefined();
|
||||
expect(config.credentials).toEqual({
|
||||
accessKeyId: "AKIAEXAMPLE",
|
||||
secretAccessKey: "secretexample",
|
||||
});
|
||||
});
|
||||
|
||||
it("uses ambient AWS access keys when only an ambient profile is set", async () => {
|
||||
vi.stubEnv("AWS_ACCESS_KEY_ID", "AKIAEXAMPLE");
|
||||
vi.stubEnv("AWS_SECRET_ACCESS_KEY", "secretexample");
|
||||
vi.stubEnv("AWS_PROFILE", "ambient-profile");
|
||||
const model = getBuiltinModel("amazon-bedrock", "us.anthropic.claude-opus-4-8");
|
||||
|
||||
const config = await captureClientConfig(model);
|
||||
|
||||
expect(config.profile).toBe("ambient-profile");
|
||||
expect(config.credentials).toEqual({
|
||||
accessKeyId: "AKIAEXAMPLE",
|
||||
secretAccessKey: "secretexample",
|
||||
});
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue