sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-05 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(durable): report settings failures when checking kept context retention

Browse source 
The idle check reads settings.contextRetentionMs from commit listeners,
reconciliation, and the expiry timer. A throwing settings getter escaped as an
unhandled rejection; it is now reported and the kept contexts are dropped.
This commit is contained in:
Mario Zechner 2026-10-06 21:10:40 +02:00
parent da866ada17
commit ae92585d3b
1 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
packages/durable/src/harness/scheduler.ts
View file

@ -426,13 +426,26 @@ export class TaskScheduler {
this.#kick();
}
/**
* `settings.contextRetentionMs`, or 0 when the host's settings throw. Kept contexts are only a cache, so dropping them
* is safe, while a throw here would escape commit listeners, reconciliation, and the expiry timer.
*/
#contextRetentionMs(): number {
try {
return this.#settings().contextRetentionMs;
} catch (error) {
this.#report(error);
return 0;
}
}
/** Resolve idle waiters, and drop each kept context whose conversation has been idle for the retention period. */
#settleIdle(): void {
for (const conversationId of this.#idleWaiters.keys()) {
if (this.#idle(conversationId)) this.#idleWaiters.resolve(conversationId);
}
const now = this.#now();
const retention = this.#settings().contextRetentionMs;
const retention = this.#contextRetentionMs();
for (const [conversationId, kept] of this.#contexts) {
if (kept.idleSince !== undefined && now - kept.idleSince >= retention) {
this.#contexts.delete(conversationId);
@ -453,7 +466,7 @@ export class TaskScheduler {
* Durable Object from being evicted, and eviction frees the contexts. There, task changes alone check expiry.
*/
#scheduleExpiry(): void {
const retention = this.#settings().contextRetentionMs;
const retention = this.#contextRetentionMs();
let at: number | undefined;
for (const kept of this.#contexts.values()) {
if (kept.idleSince !== undefined && (at === undefined || kept.idleSince + retention < at)) {
@ -1247,7 +1260,7 @@ export class TaskScheduler {
// A read of another, idle conversation starts or continues its retention period.
if (!this.#idle(conversationId)) {
this.#contexts.set(conversationId, { range, idleSince: undefined });
} else if (this.#settings().contextRetentionMs > 0) {
} else if (this.#contextRetentionMs() > 0) {
this.#contexts.set(conversationId, { range, idleSince: kept?.idleSince ?? this.#now() });
this.#scheduleExpiry();
}