sscoble/pi-mono
1
0
Fork 0
mirror of https://github.com/badlogic/pi-mono.git synced 2026-11-05 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(ai): ignore generic GitHub tokens for Copilot auth
Some checks are pending
CI / build-check-test (push) Waiting to run
Details

Browse source 
closes #4485
This commit is contained in:
Mario Zechner 2026-05-15 01:26:31 +02:00
parent 7ddc7dd1ec
commit a8af0b5e99
4 changed files with 49 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/ai/CHANGELOG.md
View file

@ -8,6 +8,7 @@
### Fixed
- Fixed GitHub Copilot model availability to ignore generic `GH_TOKEN` and `GITHUB_TOKEN` environment variables, requiring OAuth login or `COPILOT_GITHUB_TOKEN` instead ([#4485](https://github.com/earendil-works/pi/issues/4485)).
- Fixed Bedrock proxy handling to preserve `NO_PROXY` exclusions while using HTTP(S)-only proxy agents.
- Fixed GitHub Copilot Claude test coverage to use the current Claude Sonnet 4.6 model ID.
- Fixed OpenAI Responses requests for models that support disabling reasoning to send `reasoning.effort: "none"` when thinking is off.

2
packages/ai/README.md
View file

@ -1122,7 +1122,7 @@ In Node.js environments, you can set environment variables to avoid passing API
| Xiaomi MiMo Token Plan (China) | `XIAOMI_TOKEN_PLAN_CN_API_KEY` |
| Xiaomi MiMo Token Plan (Amsterdam) | `XIAOMI_TOKEN_PLAN_AMS_API_KEY` |
| Xiaomi MiMo Token Plan (Singapore) | `XIAOMI_TOKEN_PLAN_SGP_API_KEY` |
| GitHub Copilot | `COPILOT_GITHUB_TOKEN` or `GH_TOKEN` or `GITHUB_TOKEN` |
| GitHub Copilot | `COPILOT_GITHUB_TOKEN` |
When set, the library automatically uses these keys:

2
packages/ai/src/env-api-keys.ts
View file

@ -90,7 +90,7 @@ function hasVertexAdcCredentials(): boolean {
function getApiKeyEnvVars(provider: string): readonly string[] | undefined {
if (provider === "github-copilot") {
return ["COPILOT_GITHUB_TOKEN", "GH_TOKEN", "GITHUB_TOKEN"];
return ["COPILOT_GITHUB_TOKEN"];
}
// ANTHROPIC_OAUTH_TOKEN takes precedence over ANTHROPIC_API_KEY

46
packages/ai/test/env-api-keys.test.ts Normal file
View file

@ -0,0 +1,46 @@
import { afterEach, describe, expect, it } from "vitest";
import { findEnvKeys, getEnvApiKey } from "../src/env-api-keys.js";
const originalCopilotGitHubToken = process.env.COPILOT_GITHUB_TOKEN;
const originalGhToken = process.env.GH_TOKEN;
const originalGitHubToken = process.env.GITHUB_TOKEN;
afterEach(() => {
if (originalCopilotGitHubToken === undefined) {
delete process.env.COPILOT_GITHUB_TOKEN;
} else {
process.env.COPILOT_GITHUB_TOKEN = originalCopilotGitHubToken;
}
if (originalGhToken === undefined) {
delete process.env.GH_TOKEN;
} else {
process.env.GH_TOKEN = originalGhToken;
}
if (originalGitHubToken === undefined) {
delete process.env.GITHUB_TOKEN;
} else {
process.env.GITHUB_TOKEN = originalGitHubToken;
}
});
describe("environment API keys", () => {
it("does not treat generic GitHub tokens as GitHub Copilot credentials", () => {
delete process.env.COPILOT_GITHUB_TOKEN;
process.env.GH_TOKEN = "gh-token";
process.env.GITHUB_TOKEN = "github-token";
expect(findEnvKeys("github-copilot")).toBeUndefined();
expect(getEnvApiKey("github-copilot")).toBeUndefined();
});
it("resolves GitHub Copilot credentials from COPILOT_GITHUB_TOKEN", () => {
process.env.COPILOT_GITHUB_TOKEN = "copilot-token";
process.env.GH_TOKEN = "gh-token";
process.env.GITHUB_TOKEN = "github-token";
expect(findEnvKeys("github-copilot")).toEqual(["COPILOT_GITHUB_TOKEN"]);
expect(getEnvApiKey("github-copilot")).toBe("copilot-token");
});
});