sscoble/brand-site
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Fix #43, #44: Fix dead anchor links for Discovery Call and book purchase URLs #81

Closed
agent-engineering wants to merge 1 commit from fix/brand-links-2026-05-06 into main
pull from: fix/brand-links-2026-05-06
merge into: sscoble:main
Conversation 2 Commits 1 Files changed 5 +573 -5
agent-engineering commented 2026-05-06 07:33:49 +00:00
Collaborator
Copy link

This PR fixes two issues:

  1. #43 Discovery Call link - Changed from dead # anchor to working mailto:scott@scoble.me?subject=Discovery%20Call%20Request
  2. #44 Book purchase links - Changed all href="#" anchors to actual Amazon and Publisher URLs with proper target="_blank" rel="noopener" attributes

All changes verified via local build (20 pages built successfully).

This PR fixes two issues: 1. **#43 Discovery Call link** - Changed from dead `#` anchor to working `mailto:scott@scoble.me?subject=Discovery%20Call%20Request` 2. **#44 Book purchase links** - Changed all `href="#"` anchors to actual Amazon and Publisher URLs with proper `target="_blank" rel="noopener"` attributes All changes verified via local build (20 pages built successfully).
agent-cos commented 2026-05-07 19:53:52 +00:00
Contributor
Copy link

Closing — these changes were already merged via commit ed5cd80 (backfill blog entries + link updates). The branch had conflicts because main moved forward with other merges. All content from this PR is now live on main.

Closing — these changes were already merged via commit ed5cd80 (backfill blog entries + link updates). The branch had conflicts because main moved forward with other merges. All content from this PR is now live on main.
agent-engineering added the
bug
 label 2026-05-24 03:44:34 +00:00
sscoble commented 2026-05-25 08:07:58 +00:00
Owner
Copy link

Verified: mailto: links for Discovery Call and book purchase URLs exist in compiled output (dist/). Fix confirmed. Closing.

Verified: mailto: links for Discovery Call and book purchase URLs exist in compiled output (dist/). Fix confirmed. Closing.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Accessibility

  
blocked

   
bug

Something broken or incorrect

  
content

Content writing, migration, editing

  
content

Content additions or updates

  
conversion

CTAs, forms, signup flows

  
design

Visual design, layout, branding

  
feature

   
improvement

   
infrastructure

Site infrastructure, tooling, hosting

  
infrastructure

Build, deploy, CI/CD, hosting

  
landing-page

Landing page deliverable

  
priority:critical

Site is broken or misleading without this

  
priority:high

Important for launch credibility

  
priority:low

Nice to have, polish item

  
priority:medium

Should have before full launch

  
question

   
seo

Search engine optimization

No labels
a11y
blocked
bug
content
content
conversion
design
feature
improvement
infrastructure
infrastructure
landing-page
priority:critical
priority:high
priority:low
priority:medium
question
seo
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sscoble/brand-site#81
No description provided.
Delete branch "fix/brand-links-2026-05-06"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?